Simplify Revision.clone() implementation #1106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…insci#1099) List more operating systems so that web searches will find the page. Link to the operating system end of life blog post. Correct the name of Amazon Linux name. Add the most important option, upgrade to a supported operating system.
Bumps [org.jenkins-ci.plugins:plugin](https://github.com/jenkinsci/plugin-pom) from 4.76 to 4.77. - [Release notes](https://github.com/jenkinsci/plugin-pom/releases) - [Changelog](https://github.com/jenkinsci/plugin-pom/blob/master/CHANGELOG.md) - [Commits](jenkinsci/plugin-pom@plugin-4.76...plugin-4.77) --- updated-dependencies: - dependency-name: org.jenkins-ci.plugins:plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Included in parent pom 4.77
…anches from collection to list for indexed access and specific order
AniketNS
changed the title
MarkEWaite
requested changes
Feb 16, 2024
There was a problem hiding this comment.
Thanks for the pull request @AniketNS. Much appreciated.
I'm not willing to hide the fields of the Revision object because it changes the serialization of the object and risks compatibility problems for users.
The changes need to be formatted with mvn spotless:apply so that the source code continues to use a consistent formatting style.
MarkEWaite
changed the title
MarkEWaite
changed the title
|
Hey @MarkEWaite, I've made the changes you told me. Please check and tell me if it is right or if I should make any other changes. |
|
@AniketNS I am out of the office for another week. I won't look further at this until after I return. |
|
Ohh ok @MarkEWaite. |
MarkEWaite
approved these changes
Mar 9, 2024
MarkEWaite
added
the
chore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the implementation of
Revision.clone()Types of changes
What types of changes does your code introduce?