change how jgit factory are configured as it is static it can be setu…

…p only once then use some ThreadLocal for request type operations, a bit fragile but no much choice as jgit is using only some static method

Signed-off-by: Olivier Lamy <[email protected]>

pom.xml

@@ -104,11 +104,11 @@
       <artifactId>mina-sshd-api-core</artifactId>
     </dependency>
     <!-- this could be optional? -->
-<!--    <dependency>-->
-<!--      <groupId>net.i2p.crypto</groupId>-->
-<!--      <artifactId>eddsa</artifactId>-->
-<!--      <version>0.3.0</version>-->
-<!--    </dependency>-->
+    <!--    <dependency>-->
+    <!--      <groupId>net.i2p.crypto</groupId>-->
+    <!--      <artifactId>eddsa</artifactId>-->
+    <!--      <version>0.3.0</version>-->
+    <!--    </dependency>-->
     <dependency>
       <groupId>org.eclipse.jgit</groupId>
       <artifactId>org.eclipse.jgit</artifactId>

src/main/java/org/jenkinsci/plugins/gitclient/Git.java

@@ -14,7 +14,6 @@
 import java.util.logging.Level;
 import java.util.logging.Logger;
 import jenkins.model.Jenkins;
-import org.jenkinsci.plugins.gitclient.jgit.PreemptiveAuthHttpClientConnectionFactory;
 import org.jenkinsci.plugins.gitclient.verifier.HostKeyVerifierFactory;
 import org.jenkinsci.plugins.gitclient.verifier.NoHostKeyVerificationStrategy;
 
@@ -199,9 +198,7 @@ public GitClient invoke(File f, VirtualChannel channel) throws IOException, Inte
             }
 
             if (JGitApacheTool.MAGIC_EXENAME.equalsIgnoreCase(exe)) {
-                final PreemptiveAuthHttpClientConnectionFactory factory =
-                        new PreemptiveAuthHttpClientConnectionFactory();
-                return new JGitAPIImpl(f, listener, factory, hostKeyFactory);
+                return new JGitAPIImpl(f, listener, null, hostKeyFactory);
             }
             // Ensure we return a backward compatible GitAPI, even API only claim to provide a GitClient
             GitAPI gitAPI = new GitAPI(exe, f, listener, env);