Skip to content

Commit

Permalink
Use spotbugs plugin 4.8.2.0 with new exclusions (#1085)
Browse files Browse the repository at this point in the history
Preparing for future upgrade of the plugin parent pom
  • Loading branch information
MarkEWaite authored Dec 20, 2023
1 parent 75743d5 commit 6c6266d
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 0 deletions.
1 change: 1 addition & 0 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@
<jenkins.version>2.401.3</jenkins.version>
<jgit.version>6.8.0.202311291450-r</jgit.version>
<spotbugs.effort>Max</spotbugs.effort>
<spotbugs-maven-plugin.version>4.8.2.0</spotbugs-maven-plugin.version>
<spotbugs.threshold>Low</spotbugs.threshold>
<spotless.check.skip>false</spotless.check.skip>
</properties>
Expand Down
18 changes: 18 additions & 0 deletions src/spotbugs/excludesFilter.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,24 @@
Exclusions in this section have been triaged and determined to be
false positives.
-->
<Match>
<!-- Jenkins plugins generally not vulnerable to Finalizer attacks -->
<Bug pattern="CT_CONSTRUCTOR_THROW" />
<Or>
<Class name="hudson.plugins.git.GitAPI" />
<Class name="org.jenkinsci.plugins.gitclient.JGitAPIImpl$FileRepositoryImpl" />
<Class name="org.jenkinsci.plugins.gitclient.trilead.TrileadSession$ProcessImpl" />
</Or>
</Match>
<Match>
<!-- These primitive attributes need to be public to preserve the API -->
<Bug pattern="PA_PUBLIC_PRIMITIVE_ATTRIBUTE" />
<Class name="hudson.plugins.git.Tag" />
<Or>
<Field name="commitMessage" />
<Field name="commitSHA1" />
</Or>
</Match>
<Match>
<!-- intentional and accepted that it is not restored -->
<Bug pattern="SE_TRANSIENT_FIELD_NOT_RESTORED" />
Expand Down

0 comments on commit 6c6266d

Please sign in to comment.