Added GitHub signature checking feature + tests #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmmm it's weird. In my machine all the tests pass without any problem |
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
| @@ -46,6 +46,7 @@ | |||
|
|
|||
| <properties> | |||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | |||
| <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding> | |||
There was a problem hiding this comment.
It didn't pass the integration tests without this change
Moliholy
force-pushed
the
github_signature
branch
from
75395a8 to
e36d52c
Compare
christ66
pushed a commit
to christ66/ghprb-plugin
that referenced
this pull request
May 18, 2015
Using the default `refspec` prohibits the project from automatically building non-PR branches like `origin/master`. Prepending the `refspec` with the heads and remote/origin allows the project to build pull requests as well as other branches like `origin/my-feature`. This should resolve jenkinsci#77. Big thanks to janinko#77 (comment) 😄
|
Please merge in latest master. |
added 2 commits
May 20, 2015 09:31
…to github_signature Conflicts: src/main/java/org/jenkinsci/plugins/ghprb/GhprbRootAction.java src/main/java/org/jenkinsci/plugins/ghprb/GhprbTrigger.java src/test/java/org/jenkinsci/plugins/ghprb/GhprbPullRequestMergeTest.java src/test/java/org/jenkinsci/plugins/ghprb/GhprbRepositoryTest.java src/test/java/org/jenkinsci/plugins/ghprb/GhprbRootActionTest.java src/test/java/org/jenkinsci/plugins/ghprb/GhprbTestUtil.java
|
Merged! |
…to github_signature Conflicts: src/main/java/org/jenkinsci/plugins/ghprb/GhprbRepository.java src/main/java/org/jenkinsci/plugins/ghprb/GhprbTrigger.java src/main/resources/org/jenkinsci/plugins/ghprb/GhprbTrigger/config.jelly src/test/java/org/jenkinsci/plugins/ghprb/GhprbRepositoryTest.java src/test/java/org/jenkinsci/plugins/ghprb/GhprbTestUtil.java
|
Updated to the latest master. |
|
I updated master to use multiple GitHub configurations. Please update to master and make sure everything works appropriately. |
|
You will need additional property in credentials. |
…to github_signature Conflicts: src/main/java/org/jenkinsci/plugins/ghprb/GhprbRootAction.java src/main/java/org/jenkinsci/plugins/ghprb/GhprbTrigger.java src/test/java/org/jenkinsci/plugins/ghprb/GhprbRootActionTest.java src/test/java/org/jenkinsci/plugins/ghprb/GhprbTestUtil.java
|
Merged and tests passed |
nosmo
pushed a commit
to nosmo/ghprb-plugin
that referenced
this pull request
Dec 12, 2018
Using the default `refspec` prohibits the project from automatically building non-PR branches like `origin/master`. Prepending the `refspec` with the heads and remote/origin allows the project to build pull requests as well as other branches like `origin/my-feature`. This should resolve jenkinsci#77. Big thanks to janinko#77 (comment) 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon receiving a signed POST, i.e. containing a X-Hub-Signature header, that header was just ignored. Now it checks if the signature is correct, and in case it is, then it processes the POST normally.