Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-63931] change section to advanced tag for ExtendedChoiceParameterDefinition #33

Conversation

mamh2021
Copy link
Contributor

[JENKINS-63931] change section to advanced tag for ExtendedChoiceParameterDefinition

try to fixup jenkins job configure section shows unnecessary tabs

…meterDefinition

try to  fixup jenkins job configure section shows unnecessary tabs
@mamh2021
Copy link
Contributor Author

mamh2021 commented Oct 16, 2020

@vimil
hi vimil can you help me to review this PR?
I didn't find a better one to replace <f:section> Do you have any good suggestions?
Thank you very much.

@vimil
Copy link
Member

vimil commented Oct 31, 2020

Hi @mageSFC2020 could you share a screenshot

@mamh2021
Copy link
Contributor Author

mamh2021 commented Nov 2, 2020

QQ拼音截图20201103071654

here is the issue description on https://issues.jenkins-ci.org/browse/JENKINS-63931

I just replace the <f:section> to <f:advanced> to fixup this issue local. I don't know if there is a better solution.

@vimil vimil merged commit 22a7405 into jenkinsci:master Nov 3, 2020
@vimil
Copy link
Member

vimil commented Nov 3, 2020

@mageSFC2020 the screnshot looks good to me. I have merged the PR

mamh2021 pushed a commit to mamh-java/extended-choice-parameter-plugin that referenced this pull request Apr 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants