Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-60619] Java 11 compatibility #31

Merged
merged 3 commits into from
Feb 22, 2020

Conversation

mat1e
Copy link
Member

@mat1e mat1e commented Feb 12, 2020

JENKINS-60619

Boon library used by the plugin to parse JSON is not compatible with JDK 11.
This PR remove Boon library from the plugin and use groovy.json.* parser.

In your script you don't have to call Boon library anymore :

Before :

import org.boon.Boon;

def jsonEditorOptions = Boon.fromJson(/{...}/);

After :

def jsonEditorOptions = new groovy.json.JsonSlurper().parseText(/{...}/);

@mat1e mat1e requested a review from vimil February 12, 2020 13:56
@mat1e mat1e changed the title Feature/jdk11 compatibility [JENKINS-60619] jdk11 compatibility Feb 12, 2020
@mat1e mat1e changed the title [JENKINS-60619] jdk11 compatibility [JENKINS-60619] Java 11 compatibility Feb 12, 2020
@mat1e mat1e requested a review from darxriggs February 12, 2020 17:40
@vimil vimil merged commit 1b0d737 into jenkinsci:master Feb 22, 2020
@mat1e
Copy link
Member Author

mat1e commented Jul 29, 2020

@vimil,
Is it possible to make a new release of the plugin to integrate this fix ?
Actually, we are building the plugin ourself, but we prefers to install it with jenkins plugin managment as usual...

Also, we can close JENKINS-60619 after the release ;)

mamh2021 pushed a commit to mamh-java/extended-choice-parameter-plugin that referenced this pull request Apr 4, 2021
@luorigufeng
Copy link

Could you update the help manual?
https://plugins.jenkins.io/extended-choice-parameter/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants