Support swarm agent provisioning when label is assigned dynamically #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith groovy script
|
Is this change fully backwards-compatible? I'm not really deep into Jenkins so I wonder if there are downsides from switching from |
|
Thank you. The change is merged. |
|
I had to revert this PR because it caused exceptions (see #108). Can you look at it and test if it works for you? |
|
Hi, I will try to test that again at some point and check the impacts mentioned in issue 108. At the moment I had to use the traditional Docker plugin to meet my needs as the Docker Swarm plugin was not handling dynamic assignment of labels for a same multi-configuration build. Thanks for your feedback @Roemer and sorry for the non-working PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
In a multi-configuration project, the groovy-label-assignment plugin is used to assign labels dynamically to various job configurations (variants). It allows to provision a different docker agent depending of the variant to build within a same project (docker image is different depending of the variant).
Here are the small changes required to trigger and provision the docker-swarm agent using Docker Swarm Plugin with Groovy Label Assignment.