Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker fixtures for Java 11 #38

Merged
merged 1 commit into from
Jul 6, 2022

Conversation

timja
Copy link
Member

@timja timja commented Jul 2, 2022

ATH is failing on recent core

see jenkinsci/acceptance-test-harness#807

Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a bunch for addressing, though looks like spotbugs got much more strict 👀

@timja
Copy link
Member Author

timja commented Jul 2, 2022

There’s a test failing due to a locale change at least for me locally will look later

@timja timja force-pushed the update-docker-fixtures branch 2 times, most recently from 9893d2c to a25bde0 Compare July 2, 2022 20:22
ATH is failing on recent core
@timja timja force-pushed the update-docker-fixtures branch from a25bde0 to 81b0ba3 Compare July 2, 2022 20:23
@@ -50,12 +51,10 @@ public void smokes() throws Exception {
public void locale() throws Exception {
JavaContainer c = javaContainerRule.get();
// cf. https://stackoverflow.com/a/4384506/12916
assertThat(c.popen(new CommandBuilder("jrunscript", "-e", "'println(java.lang.System.getProperty(\"file.encoding\") + \" vs. \" + java.lang.System.getProperty(\"sun.jnu.encoding\"))'")).verifyOrDieWith("could not run jrunscript"),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jrunscript is deprecated for removal in 11 and removed in 14.

allOf(containsString("exists: true"), containsString("name: hello%C4%8D%E0%A5%90")));
assertThat(c.popen(new CommandBuilder("sh", "-c", "'ls | native2ascii -encoding UTF-8'")).verifyOrDieWith("could not run ls"),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -4,7 +4,7 @@
<parent>
<groupId>org.jenkins-ci</groupId>
<artifactId>jenkins</artifactId>
<version>1.54</version>
<version>1.76</version>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the pom file wouldn't build on Java 11 without some updates.

I didn't bother going to latest which requires Java 11 as we still want to use this library on 8 for a bit for ATH.
I know I could add some trickery but I don't think needed for this repo.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it is deprecated anyway.

@timja
Copy link
Member Author

timja commented Jul 2, 2022

There’s a test failing due to a locale change at least for me locally will look later

heh, that just fails in my IDE I didn't manage to fix it, but via maven it works fine and the only issue was native2ascii getting removed

@timja timja requested a review from Vlatombe July 5, 2022 21:12
@timja
Copy link
Member Author

timja commented Jul 5, 2022

@jglick / @Vlatombe any chance of a quick release please? this is breaking ATH since Java 11 move.

(very surprised this wasn't tested -.-)

@jglick jglick added the bug label Jul 6, 2022
@@ -4,7 +4,7 @@
<parent>
<groupId>org.jenkins-ci</groupId>
<artifactId>jenkins</artifactId>
<version>1.54</version>
<version>1.76</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it is deprecated anyway.

@jglick jglick merged commit a9ddf67 into jenkinsci:master Jul 6, 2022
@timja timja deleted the update-docker-fixtures branch July 6, 2022 15:25
@jglick
Copy link
Member

jglick commented Jul 6, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants