-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docker fixtures for Java 11 #38
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a bunch for addressing, though looks like spotbugs got much more strict 👀
There’s a test failing due to a locale change at least for me locally will look later |
9893d2c
to
a25bde0
Compare
ATH is failing on recent core
a25bde0
to
81b0ba3
Compare
@@ -50,12 +51,10 @@ public void smokes() throws Exception { | |||
public void locale() throws Exception { | |||
JavaContainer c = javaContainerRule.get(); | |||
// cf. https://stackoverflow.com/a/4384506/12916 | |||
assertThat(c.popen(new CommandBuilder("jrunscript", "-e", "'println(java.lang.System.getProperty(\"file.encoding\") + \" vs. \" + java.lang.System.getProperty(\"sun.jnu.encoding\"))'")).verifyOrDieWith("could not run jrunscript"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jrunscript is deprecated for removal in 11 and removed in 14.
allOf(containsString("exists: true"), containsString("name: hello%C4%8D%E0%A5%90"))); | ||
assertThat(c.popen(new CommandBuilder("sh", "-c", "'ls | native2ascii -encoding UTF-8'")).verifyOrDieWith("could not run ls"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed in 9, https://bugs.openjdk.org/browse/JDK-8074431
@@ -4,7 +4,7 @@ | |||
<parent> | |||
<groupId>org.jenkins-ci</groupId> | |||
<artifactId>jenkins</artifactId> | |||
<version>1.54</version> | |||
<version>1.76</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the pom file wouldn't build on Java 11 without some updates.
I didn't bother going to latest which requires Java 11 as we still want to use this library on 8 for a bit for ATH.
I know I could add some trickery but I don't think needed for this repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah it is deprecated anyway.
heh, that just fails in my IDE I didn't manage to fix it, but via maven it works fine and the only issue was native2ascii getting removed |
@@ -4,7 +4,7 @@ | |||
<parent> | |||
<groupId>org.jenkins-ci</groupId> | |||
<artifactId>jenkins</artifactId> | |||
<version>1.54</version> | |||
<version>1.76</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah it is deprecated anyway.
ATH is failing on recent core
see jenkinsci/acceptance-test-harness#807