Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize Tooling #89

Merged
merged 3 commits into from
Sep 4, 2023

Conversation

sghill-rewrite
Copy link
Contributor

Hi,

This PR aims to modernize the parent pom and fix the SpotBugs issues raised by the newer tooling. In some cases I suppressed the SpotBugs warnings. Ideally they'd be fixed, but I didn't want to make this change too big.

This was generated by the ModernizePlugin recipe on moderne.io and manually touched up.

Testing done

Ran mvn clean verify locally.

Submitter checklist

Preview Give feedback

@NotMyFault NotMyFault requested a review from a team August 30, 2023 14:12
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jenkinsci/disk-usage-plugin-developers any chance this could be merged? That would facilitate testing the plugin on Java 21.

@froque froque merged commit 54fe8e7 into jenkinsci:master Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants