fix missing icons with non-root webapp context #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some icons are missing when Jenkins is deployed, for instance, with a "/jenkins/" webapp context. See here for an explanation:
https://wiki.jenkins-ci.org/display/JENKINS/Hyperlinks+in+HTML
Note that in the same "jobMain.jelly" file, there is also a "
<summary icon='...'>" (/lib/husdon taglib) with an icon URL, which does not require the ${resURL} prefix. This is because it's already added by the taglib. My changes only affect the pure-HTML "<img src='...'>" tags.