Replace joda-time dependency with java.time
#125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Was planning to get rid of joda-time, but hadn't found the time yet... If I realized it were just 2 or 3 places... |
|
Well, tests run again, but they don't test the actual values used, so I don't know if the result is the same as before... Will merge if nobody objects in the coming days... |
TobiX
approved these changes
Oct 20, 2021
|
Amendments look right. I am not experienced in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jenkinsci/bom#682 (comment)
Tried to follow https://blog.joda.org/2014/11/converting-from-joda-time-to-javatime.html though it was not particularly helpful. This code compiles; whether it works, I cannot say (I do not even know what the functionality being edited here is for).