Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See jenkinsci/jenkins-test-harness#550. Commons Lang 3 is only exposed to tests by accident, which I intend to fix soon by shading this library. Its accidental presence leads to undefined behavior if someone actually depends on the Commons Lang 3 API plugin (basically whichever one happens to be first on the classpath will win). I plan to fix all of this soon, but before I can do that, this plugin needs to stop relying on this implementation detail of the current test harness.
There are two ways to deal with this: either depend on Commons Lang 2.x instead (which is shipped as part of Jenkins core), or add an explicit (test-scoped) dependency on the Commons Lang 3 API Jenkins plugin.
For this PR I opted to do the first approach, since it didn't seem like this plugin cared enough about which version of
StringUtils
was being used.Testing done
mvn clean verify
against a development copy of the test harness with Commons Lang 3 shadedSubmitter checklist