Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop dependency on Commons Lang 3 #201

Merged
merged 1 commit into from
Jun 24, 2023
Merged

Conversation

basil
Copy link
Member

@basil basil commented Jun 23, 2023

See jenkinsci/jenkins-test-harness#550. Commons Lang 3 is only exposed to tests by accident, which I intend to fix soon by shading this library. Its accidental presence leads to undefined behavior if someone actually depends on the Commons Lang 3 API plugin (basically whichever one happens to be first on the classpath will win). I plan to fix all of this soon, but before I can do that, this plugin needs to stop relying on this implementation detail of the current test harness.

There are two ways to deal with this: either depend on Commons Lang 2.x instead (which is shipped as part of Jenkins core), or add an explicit (test-scoped) dependency on the Commons Lang 3 API Jenkins plugin.

For this PR I opted to do the first approach, since it didn't seem like this plugin cared enough about which version of StringUtils was being used.

Testing done

mvn clean verify against a development copy of the test harness with Commons Lang 3 shaded

Submitter checklist

Preview Give feedback

@strangelookingnerd
Copy link
Contributor

@basil Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants