-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Credentials.forRun
to contextualize secrets
#293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
changed the title
Introduce
Introduce Mar 23, 2022
Credentials.forRun
to comtextualize secretsCredentials.forRun
to contextualize secrets
This was referenced Mar 23, 2022
MarkEWaite
added a commit
to MarkEWaite/docker-lfs
that referenced
this pull request
Mar 26, 2022
Includes GitHub App authentication enhancement from Jesse Glick for credentials by context. jenkinsci/github-branch-source-plugin#527 needs this so that it can use the enhancement in jenkinsci/credentials-plugin#293 Otherwise `withCredentials` works but `checkout scm` does not work
MarkEWaite
added a commit
to MarkEWaite/docker-lfs
that referenced
this pull request
Mar 26, 2022
jenkinsci/credentials-plugin#293 to contextualize secrets in an incremental build for testing
timja
approved these changes
Mar 26, 2022
MarkEWaite
approved these changes
Mar 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've run it in my Jenkins test instance and have not detected any issues. I have not exercised contextualized secrets yet in that instance.
jglick
added a commit
to jglick/github-branch-source-plugin-1
that referenced
this pull request
Mar 26, 2022
jglick
added a commit
to jglick/credentials-binding-plugin
that referenced
this pull request
Mar 26, 2022
This was referenced Mar 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jenkinsci/github-branch-source-plugin#527 is a demonstrated use case, and jenkinsci/conjur-credentials-plugin#21 a proposed one.
This new SPI requires use of the
CredentialsProvider.findCredentialById
method, which passes a (mandatory)Run
argument and is the normal way to look up a particular credential during a build. (credentials-binding
has long used it—jenkinsci/credentials-binding-plugin#169 is the integration test—and the revised version of jenkinsci/git-plugin#1242 is able to use it consistently as well.) There are other lookup methods which take anItem
(~Job
) or evenItemGroup
(~Jenkins
/Folder
/MultiBranchProject
/OrganizationFolder
) context, which would suffice for jenkinsci/github-branch-source-plugin#527 (which would usually be inspecting aMultiBranchProject
though I left in support for standaloneJob
projects using thegithub
plugin’s project property as well). If and when such an SPI becomes desirable, it should be possible to compatibly introduceCredentials.forItem
(defaulting tothis
, rewrite the default offorRun
to delegate toforItem(run.getParent())
) or evenforItemGroup
(similar delegation chain).