Show credential ID in DomainWrapper view #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: the proposed design of the domain-scoped credentials screen is not the final one, hence this PR is marked as a Draft to let us discuss it. |
|
This is what the proposed change would render:
|
|
Makes sense to me. I don't see any reason the ID isn't shown for domains. I'm not great at UI design, but this proposal looks simple and satisfactory to me. |
oleg-nenashev
approved these changes
Nov 30, 2019
timja
approved these changes
Feb 22, 2020
jvz
approved these changes
Feb 24, 2020
jvz
added a commit
to jvz/acceptance-test-harness
that referenced
this pull request
Apr 6, 2020
This updates credential lookup for the plugin post-application of jenkinsci/credentials-plugin#120
|
See linked PR for acceptance test updates affected by this change. It seems they were a bit fragile and were checking for the description on the tooltip! I've updated the test to do an additional xpath query for the updated UI. |
chriskilding
deleted the
support/show-credential-id-in-domain-wrapper-view
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the credential ID is shown in the global credentials screen (
/credentials), but not in the domain-scoped credentials screen (/credentials/store/system/domain/_/), which makes it a little harder for users to work with domain-scoped credentials.This PR adds the credential ID to the domain-scoped credentials screen, so that users no longer need to look at the path in their address bar to work out the credential ID they should paste into their Jenkinsfiles.