Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert JUnit3 to JUnit4 #285

Merged
merged 9 commits into from
Oct 9, 2024
Merged

Convert JUnit3 to JUnit4 #285

merged 9 commits into from
Oct 9, 2024

Conversation

darinpope
Copy link
Contributor

@darinpope darinpope commented Oct 9, 2024 •
edited
Loading

Convert HudsonTestCase and TestCase to matching JUnit 4 tests

Testing done

  • ran mvn spotless:apply clean verify
  • automated tests pass

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@darinpope darinpope changed the title convert junit3 to junit4 Convert JUnit3 to JUnit4 Oct 9, 2024
@MarkEWaite MarkEWaite added the test Improve tests or test infrastructure label Oct 9, 2024
@MarkEWaite MarkEWaite self-assigned this Oct 9, 2024
@darinpope darinpope marked this pull request as ready for review October 9, 2024 21:02
@MarkEWaite MarkEWaite merged commit 38ed979 into jenkinsci:master Oct 9, 2024
17 checks passed
@darinpope darinpope deleted the junit3-to-4 branch October 9, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MarkEWaite MarkEWaite

Labels
test Improve tests or test infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darinpope @MarkEWaite