Remove unnecessary jelly conditional code #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The configuration form modernization happened in Jenkins 2.277.1. This plugin requires at least Jenkins 2.361.4. The divBasedFormLayout conditional will always be true. Inline the <div> tags rather than using a conditional.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unnecessary jelly conditional code
The configuration form modernization happened in Jenkins 2.277.1. This plugin requires at least Jenkins 2.361.4. The divBasedFormLayout conditional will always be true. Inline the
Testing done
Interactively tested to assure that I could see the message in the modified file and that it was displayed correctly without surprised. Ran more tests based on the description in JENKINS_67814 and confirmed those cases are working correctly as well.
Submitter checklist