This repository has been archived by the owner on Nov 19, 2024. It is now read-only.
Convert delta fractions to percentages when used in quality gates #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delta values are internally stored as fractions, but a user expects them as percentages when they are displayed or used in thresholds. So values in the range [-1, 1] are converted to percentages in the range [-100%, 100%] before passed to the quality gate evaluation. Fixes https://github.com/jenkinsci/code-coverage-api-plugin/issues/689
Codecov Report
@@ Coverage Diff @@
## master #703 +/- ##
============================================
+ Coverage 73.38% 73.54% +0.16%
- Complexity 1667 1689 +22
============================================
Files 129 130 +1
Lines 6240 6278 +38
Branches 669 676 +7
============================================
+ Hits 4579 4617 +38
Misses 1439 1439
Partials 222 222
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Thank you so much @uhafner for the quick fix on this! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delta values are internally stored as fractions, but a user expects them as percentages when they are displayed or used in thresholds. So values in the range [-1, 1] should be converted to percentages in the range [-100%, 100%] before passed to the quality gate evaluation.
Fixes https://github.com/jenkinsci/code-coverage-api-plugin/issues/689