Skip to content
This repository has been archived by the owner on Nov 19, 2024. It is now read-only.

Make trend charts theme-aware #676

Merged
merged 5 commits into from
May 19, 2023
Merged

Make trend charts theme-aware #676

merged 5 commits into from
May 19, 2023

Conversation

uhafner
Copy link
Member

@uhafner uhafner commented May 15, 2023

Use colors from the new Echarts JenkinsPalette for line and bar charts.

Downstream PR of jenkinsci/echarts-api-plugin#287.

Bildschirmfoto 2023-05-15 um 11 40 29
Bildschirmfoto 2023-05-15 um 11 40 35
Bildschirmfoto 2023-05-15 um 11 41 25
Bildschirmfoto 2023-05-15 um 11 41 30

This will also fix #673 and #228.

Use colors from the new Echarts `JenkinsPalette` for line and bar
charts.
@uhafner uhafner added the enhancement Enhancement of existing functionality label May 15, 2023
@uhafner uhafner marked this pull request as draft May 15, 2023 20:06
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i like it

@uhafner uhafner marked this pull request as ready for review May 19, 2023 22:50
@uhafner uhafner enabled auto-merge May 19, 2023 23:07
@uhafner uhafner disabled auto-merge May 19, 2023 23:10
@uhafner uhafner merged commit c041e39 into master May 19, 2023
@uhafner uhafner deleted the theme-colors branch May 19, 2023 23:10
@@ -27,7 +29,7 @@
*
* @author Ullrich Hafner
*/
class CoverageSeriesBuilderTest {
class CoverageSeriesBuilderTest extends ResourceTest {

Check notice

Code scanning / CodeQL

Unused classes and interfaces

Unused class: CoverageSeriesBuilderTest is not referenced within this codebase. If not used as an external API it should be removed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Enhancement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code Coverage Trend: Too low color contrast between line and branch coverage
2 participants