Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix primaryView & viewsTabBar missing when views are empty #437

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix primaryView & viewsTabBar missing when views are empty #437

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/main/java/com/cloudbees/hudson/plugins/folder/AbstractFolder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,11 @@
} catch (IOException e) {
LOGGER.log(Level.WARNING, "Failed to set up the initial view", e);
}
return new DefaultFolderViewHolder(views, null, newDefaultViewsTabBar());
if (primaryView != null) {

Check warning on line 305 in src/main/java/com/cloudbees/hudson/plugins/folder/AbstractFolder.java

View check run for this annotation

ci.jenkins.io / Code Coverage

Partially covered line 

Line 305 is only partially covered, one branch is missing
primaryView = AllView.migrateLegacyPrimaryAllViewLocalizedName(views, primaryView);

Check warning on line 306 in src/main/java/com/cloudbees/hudson/plugins/folder/AbstractFolder.java

View check run for this annotation

ci.jenkins.io / Code Coverage

Not covered line 

Line 306 is not covered by tests
}
return new DefaultFolderViewHolder(views, primaryView, viewsTabBar == null ? newDefaultViewsTabBar()

Check warning on line 308 in src/main/java/com/cloudbees/hudson/plugins/folder/AbstractFolder.java

View check run for this annotation

ci.jenkins.io / Code Coverage

Partially covered line 

Line 308 is only partially covered, one branch is missing
: viewsTabBar);
}

protected FolderIcon newDefaultFolderIcon() {
Expand Down
Loading