Skip to content

Commit

Permalink
Fix primaryView missing when views are empty
Browse files Browse the repository at this point in the history
  • Loading branch information
Gemini2015 committed Nov 28, 2024
1 parent 917eb99 commit ff6ca73
Showing 1 changed file with 5 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,11 @@ protected AbstractFolderViewHolder newFolderViewHolder() {
} catch (IOException e) {
LOGGER.log(Level.WARNING, "Failed to set up the initial view", e);
}
return new DefaultFolderViewHolder(views, null, newDefaultViewsTabBar());
if (primaryView != null) {

Check warning on line 305 in src/main/java/com/cloudbees/hudson/plugins/folder/AbstractFolder.java

View check run for this annotation

ci.jenkins.io / Code Coverage

Partially covered line

Line 305 is only partially covered, one branch is missing
primaryView = AllView.migrateLegacyPrimaryAllViewLocalizedName(views, primaryView);

Check warning on line 306 in src/main/java/com/cloudbees/hudson/plugins/folder/AbstractFolder.java

View check run for this annotation

ci.jenkins.io / Code Coverage

Not covered line

Line 306 is not covered by tests
}
return new DefaultFolderViewHolder(views, primaryView, viewsTabBar == null ? newDefaultViewsTabBar()

Check warning on line 308 in src/main/java/com/cloudbees/hudson/plugins/folder/AbstractFolder.java

View check run for this annotation

ci.jenkins.io / Code Coverage

Partially covered line

Line 308 is only partially covered, one branch is missing
: viewsTabBar);
}

protected FolderIcon newDefaultFolderIcon() {
Expand Down

0 comments on commit ff6ca73

Please sign in to comment.