Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: Use monospace font to render Disk Usage and Amount #102

Merged
merged 1 commit into from
Oct 12, 2024
Merged

style: Use monospace font to render Disk Usage and Amount #102

merged 1 commit into from
Oct 12, 2024

Conversation

rahulsom
Copy link
Contributor

Without this, the width of 405215138 looks less than that of 399089984.

Testing done

The UI uses monospace font for those two columns.

Submitter checklist
Preview Give feedback

@rahulsom
style: Use monospace font to render Disk Usage and Amount
e5c3e11 
Without this, the width of `405215138` looks less than that of `399089984`.
@rahulsom rahulsom requested a review from a team as a code owner February 19, 2024 17:15
aheritier
aheritier approved these changes Feb 19, 2024
View reviewed changes
Copy link
Member

@aheritier aheritier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@rahulsom
Copy link
Contributor Author

Hi! Can we merge this?

@PierreBtz
Copy link
Contributor

Thanks for the contribution

@PierreBtz PierreBtz merged commit 47f4ee8 into jenkinsci:master Oct 12, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aheritier aheritier aheritier approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rahulsom @PierreBtz @aheritier