-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refresh plugin for July 2023 #208
Conversation
version: next | ||
env: | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
permissions: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Subsuming #166.
@@ -2,6 +2,6 @@ | |||
<extension> | |||
<groupId>io.jenkins.tools.incrementals</groupId> | |||
<artifactId>git-changelist-maven-extension</artifactId> | |||
<version>1.3</version> | |||
<version>1.7</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest version at the time of this writing.
buildPlugin(useContainerAgent: true, configurations: [ | ||
[platform: 'linux', jdk: 17], | ||
[platform: 'windows', jdk: 11], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following the latest archetype at the time of this writing.
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd"> | ||
<modelVersion>4.0.0</modelVersion> | ||
<parent> | ||
<groupId>org.jenkins-ci.plugins</groupId> | ||
<artifactId>plugin</artifactId> | ||
<version>4.41</version> | ||
<version>4.71</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest version at the time of this writing.
<java.level>8</java.level> | ||
<jenkins.version>2.303.1</jenkins.version> | ||
<gitHubRepo>jenkinsci/${project.artifactId}-plugin</gitHubRepo> | ||
<jenkins.version>2.387.3</jenkins.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following the archetype.
</properties> | ||
|
||
<url>https://github.com/jenkinsci/chucknorris-plugin</url> | ||
<url>https://github.com/jenkinsci/${project.artifactId}-plugin</url> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following the archetype.
<releases> | ||
<enabled>true</enabled> | ||
</releases> | ||
<snapshots> | ||
<enabled>false</enabled> | ||
</snapshots> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following the archetype.
|
||
import hudson.model.Result; | ||
import hudson.plugins.chucknorris.RoundhouseAction; | ||
import hudson.plugins.chucknorris.Style; | ||
|
||
public class ChuckNorrisStepTest { | ||
@Rule | ||
public RestartableJenkinsRule story = new RestartableJenkinsRule(); | ||
public JenkinsRule j = new JenkinsRule(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RestartableJenkinsRule
isn't needed in this test class.
p.setDefinition(new CpsFlowDefinition( | ||
"chuckNorris()\n" + | ||
"semaphore 'wait'\n" | ||
)); | ||
, true)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adapting to a method deprecation by enabling the Script Security sandbox.
|
||
story.j.waitForCompletion(b1); | ||
story.j.assertBuildStatus(Result.FAILURE, b2); | ||
j.waitForCompletion(b2); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixing test flakiness.
No description provided.