Bump configuration-as-code from 1.34 to 1.35 #172

timja · 2020-01-17T21:29:39Z

…rness renamed)""

hack as I can't change the Jenkinsfile, note in this case it wasn't noticed because the Jenkinsfile allows no test results, the pct build is failing but the process doesn't exit with 1 as test_failures are allowed, assuming they are reported on later, but because the build failed there's no actual test failure. Not intending this for merge, just so we can see the failures as we fix them

timja · 2020-01-18T09:10:32Z

Currently failing on:
jenkinsci/script-security-plugin#284
and ssh-credentials

ssh-credentials bump has caused:

Require upper bound dependencies error for org.jenkins-ci:trilead-ssh2:build-217-jenkins-14 paths to dependency are:
+-io.jenkins.tools.bom:sample:6-SNAPSHOT
  +-org.jenkins-ci.main:jenkins-core:2.176.3
    +-org.jenkins-ci:trilead-ssh2:build-217-jenkins-14
and
+-io.jenkins.tools.bom:sample:6-SNAPSHOT
  +-org.jenkins-ci.main:jenkins-core:2.176.3
    +-org.jenkins-ci.main:cli:2.176.3
      +-org.jenkins-ci:trilead-ssh2:build214-jenkins-1
and
+-io.jenkins.tools.bom:sample:6-SNAPSHOT
  +-org.jenkins-ci.main:jenkins-core:2.176.3
    +-org.kohsuke:trilead-putty-extension:1.2
      +-org.jenkins-ci:trilead-ssh2:build214-jenkins-1
and
+-io.jenkins.tools.bom:sample:6-SNAPSHOT
  +-org.jenkins-ci.plugins:ssh-slaves:1.30.2
    +-org.jenkins-ci.plugins:ssh-credentials:1.18.1
      +-org.jenkins-ci.plugins:trilead-api:1.0.5
        +-org.jenkins-ci:trilead-ssh2:build-217-jenkins-16

commented here:
jenkinsci/ssh-credentials-plugin#49 (comment)

Just so we can check we got all the required plugins

jetersen · 2020-01-20T20:02:56Z

let's remove the fail fast, while testing? 🤔

timja · 2020-01-20T20:04:20Z

let's remove the fail fast, while testing? 🤔

if i change the Jenkinsfile it will just be ignored,
maybe @jglick will change it for us 😉

jetersen · 2020-01-20T20:05:03Z

if we ask nicely maybe we can get commit access? 🙇

timja · 2020-01-20T20:05:34Z

if we ask nicely maybe we can get commit access? 🙇

Pretty please Jesse 😄

timja · 2020-01-24T16:44:36Z

Seeing if the ansicolor failure is a flake or consistent

timja · 2020-01-24T20:28:33Z

failed this time on script-security.
would be good if we could get failFast disabled so we can see all the errors though.

cc @jglick

timja · 2020-01-24T20:35:46Z

FTR jenkinsci/script-security-plugin#284 (comment)

jglick · 2020-01-28T00:23:54Z

would be good if we could get failFast disabled

I am reluctant to disable failFast in master. Builds are very expensive, and there are a lot of failing PRs. I suppose I can try to load this flag from a separate file, so untrusted contributors can set it temporarily in a PR. Also I can give some people commit access.

amuniz · 2020-02-12T13:26:52Z

Oh, and this is why I don't like the PCT... it's testing a quite unreal setup.

timja · 2020-02-12T13:58:08Z

thanks for taking a look @amuniz,

From what I can see it should be managed though,
https://github.com/jenkinsci/bom/blob/bom-4/bom-latest/pom.xml#L249

In that bom release it's importing other boms up until latest,
https://github.com/jenkinsci/bom/blob/bom-4/bom-2.138.x/pom.xml#L13-L19

amuniz · 2020-02-12T14:03:49Z

How is bom-latest being picked up? I don't see it in https://github.com/jenkinsci/bom/blob/bom-4/bom-2.138.x/pom.xml

It looks they are picked up backward, but not forward (which seems correct).

timja · 2020-02-12T14:05:07Z

If I run:

mvn help:effective-pom

I see:

      <dependency>
        <groupId>org.jenkins-ci.plugins</groupId>
        <artifactId>structs</artifactId>
        <version>1.20</version>
      </dependency>

https://github.com/jenkinsci/bom/blob/bom-4/bom-2.138.x/pom.xml#L15

https://github.com/jenkinsci/bom/blob/bom-4/bom-2.150.x/pom.xml#L15

...

amuniz · 2020-02-12T14:28:37Z

Ah, ok. Then I have no idea 🤷‍♂️

timja · 2020-02-12T14:37:47Z

@jglick any ideas?

timja · 2020-02-12T14:40:22Z

Also @amuniz the bom change in workflow-step-api is unreleased, but even if I checkout the released version I have the same issue,

https://github.com/jenkinsci/workflow-step-api-plugin/pull/54/files#diff-600376dffeb79835ede4a0b285078036L88

jglick · 2020-02-12T14:42:13Z

Sorry, I have no time to work on this at the moment.

this is why I don't like the PCT... it's testing a quite unreal setup

Yes, no one likes it really, but we are sort of stuck with it because nearly all our test coverage presumes a Maven flat test classpath. There have been abortive efforts to create better systems.

…into revert-164-revert-161-patch-1

failFast

jglick · 2020-03-05T20:47:28Z

You are busy! Thanks for moving this repo along.

oleg-nenashev

I would rather bite the bullet and integrate it, even with Folders plugin suppressed. We can fix it in a follow-up, PCT patch is needed IIUC

timja and others added 5 commits January 17, 2020 20:58

Revert "Revert "Bump configuration-as-code from 1.34 to 1.35 (test ha…

e66bbe2

…rness renamed)""

Bump plugins after jcasc fix

1d85a70

chmod +x prep.sh

bc5fb72

chmod +x pct.sh

7ff6ddf

timja mentioned this pull request Jan 18, 2020

Upgrade to use jcasc test harness jenkinsci/git-client-plugin#490

Merged

timja added 5 commits January 18, 2020 14:28

Use SNAPSHOTs till release

c3342a1

Just so we can check we got all the required plugins

Ignore local files for running PCT

5f1d024

Use released git plugin versions

26c1a5c

Snapshot doesn't work

6254b7d

Bump ssh-credentials

9696b39

This was referenced Jan 18, 2020

Revert "Bump configuration-as-code from 1.34 to 1.35 (test harness renamed)" #164

Merged

Upgrade to use jcasc test harness jenkinsci/ssh-credentials-plugin#49

Merged

Use backported ssh-credentials

349476b

jetersen mentioned this pull request Jan 20, 2020

Upgrade to use jcasc test harness jenkinsci/script-security-plugin#284

Merged

timja requested a review from jglick January 20, 2020 20:06

Bump ssh-slaves

ff3580a

timja closed this Jan 24, 2020

timja reopened this Jan 24, 2020

jglick mentioned this pull request Jan 28, 2020

Read failFast from a file #180

Merged

Bump script-security from 1.68 to 1.69

285b75d

timja mentioned this pull request Feb 12, 2020

Use BOM jenkinsci/workflow-step-api-plugin#54

Merged

jglick removed their request for review February 18, 2020 22:40

Update pom.xml

96b6981

oleg-nenashev self-requested a review February 26, 2020 09:28

timja mentioned this pull request Mar 3, 2020

Bump git from 4.0.0 to 4.2.0 #198

Closed

timja added 2 commits March 3, 2020 21:42

Move structs to top

d241f21

Merge branch 'revert-164-revert-161-patch-1' of github.com:timja/bom …

7e17b8c

…into revert-164-revert-161-patch-1

timja mentioned this pull request Mar 4, 2020

Bump configuration-as-code from 1.34 to 1.36 #199

Closed

timja added 2 commits March 5, 2020 19:08

Ignore cloudbees-folder

38c6400

Revert unneeded changes

29259ee

timja commented Mar 5, 2020

View reviewed changes

failFast Outdated Show resolved Hide resolved

Update failFast

be11c16

timja requested review from jglick and jetersen March 5, 2020 20:44

timja marked this pull request as ready for review March 5, 2020 20:44

timja closed this Mar 10, 2020

timja reopened this Mar 10, 2020

jglick added the dependencies Pull requests that update a dependency file label Mar 10, 2020

oleg-nenashev approved these changes Apr 8, 2020

View reviewed changes

timja merged commit 3713b8a into jenkinsci:master Apr 8, 2020

timja deleted the revert-164-revert-161-patch-1 branch April 8, 2020 08:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump configuration-as-code from 1.34 to 1.35 #172

Bump configuration-as-code from 1.34 to 1.35 #172

timja commented Jan 17, 2020 •

edited by jetersen

Loading

timja commented Jan 18, 2020 •

edited

Loading

jetersen commented Jan 20, 2020 •

edited

Loading

timja commented Jan 20, 2020

jetersen commented Jan 20, 2020

timja commented Jan 20, 2020

timja commented Jan 24, 2020

timja commented Jan 24, 2020 •

edited

Loading

timja commented Jan 24, 2020

jglick commented Jan 28, 2020

amuniz commented Feb 12, 2020

timja commented Feb 12, 2020

amuniz commented Feb 12, 2020

timja commented Feb 12, 2020

amuniz commented Feb 12, 2020

timja commented Feb 12, 2020

timja commented Feb 12, 2020

jglick commented Feb 12, 2020

jglick commented Mar 5, 2020

oleg-nenashev left a comment

Bump configuration-as-code from 1.34 to 1.35 #172

Bump configuration-as-code from 1.34 to 1.35 #172

Conversation

timja commented Jan 17, 2020 • edited by jetersen Loading

timja commented Jan 18, 2020 • edited Loading

jetersen commented Jan 20, 2020 • edited Loading

timja commented Jan 20, 2020

jetersen commented Jan 20, 2020

timja commented Jan 20, 2020

timja commented Jan 24, 2020

timja commented Jan 24, 2020 • edited Loading

timja commented Jan 24, 2020

jglick commented Jan 28, 2020

amuniz commented Feb 12, 2020

timja commented Feb 12, 2020

amuniz commented Feb 12, 2020

timja commented Feb 12, 2020

amuniz commented Feb 12, 2020

timja commented Feb 12, 2020

timja commented Feb 12, 2020

jglick commented Feb 12, 2020

jglick commented Mar 5, 2020

oleg-nenashev left a comment

Choose a reason for hiding this comment

timja commented Jan 17, 2020 •

edited by jetersen

Loading

timja commented Jan 18, 2020 •

edited

Loading

jetersen commented Jan 20, 2020 •

edited

Loading

timja commented Jan 24, 2020 •

edited

Loading