Bump BOM and explicitly depend on caffeine-api to fix LoadingCache.refresh
#2435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
rsandell
approved these changes
May 8, 2023
7 tasks
|
@olamy please consider merging & releasing soon, as the |
olamy
reviewed
May 8, 2023
| @@ -792,8 +764,8 @@ | |||
| <rules> | |||
| <bannedDependencies> | |||
| <excludes> | |||
| <!-- TODO very likely wrong --> | |||
There was a problem hiding this comment.
Edit the comment if you like, but can we ship this, or perhaps some more minimal version limited to caffeine-api without a general BOM cleanup?
There was a problem hiding this comment.
except the comment. everything looks good.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise you get constant errors like
Caused by ben-manes/caffeine#143 as noted in ben-manes/caffeine#543 (comment) and picked up from jenkinsci/caffeine-api-plugin#79. Source-compatible but binary-incompatible, so suffices to rebuild against 3.x.