[JENKINS-58732] Remove docker-workflow dep from blueocean-pipeline-editor - update minimum jenkins core version 2.222.4 #2132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@olamy @dwnusbaum et al. |
olamy
reviewed
Mar 7, 2021
| @@ -29,7 +29,7 @@ | |||
| <changelist>-SNAPSHOT</changelist> | |||
| <gitHubRepo>jenkinsci/blueocean-plugin</gitHubRepo> | |||
| <java.level>8</java.level> | |||
| <jenkins.version>2.176.4</jenkins.version> <!-- Should be kept in sync with the version resulting from Dockerfile FROM statement--> | |||
| <jenkins.version>2.222.4</jenkins.version> | |||
There was a problem hiding this comment.
just figured out this upgrade is not so trivial... :( because the Jenkinsfile need to be upgraded as well to have BO ATH running with this version of Jenkins. And this not working due to some issue with https://github.com/jenkinsci/java-client-api. I will try to figure out this next week.
olamy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See JENKINS-58732. Amends #2056 by @Vlatombe to pick up jenkinsci/pipeline-model-definition-plugin#393 via jenkinsci/bom#415, which in turn requires switching to a somewhat more recent LTS baseline (2.176.x → 2.222.x). While I am here, using the BOM more consistently.
Reviewer checklist