Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PCT failures when running against Jenkins 2.249+ #2094

Merged
merged 7 commits into from
Sep 2, 2020

Conversation

dwnusbaum
Copy link
Member

Description

This PR fixes three tests that are failing in the PCT when running against Jenkins 2.249:

  • TryBlueOceanMenuTest.testOpenBlueOcean: Issue is that [JENKINS-61973] Restyle sidebar tasks jenkins#4700 changed the styling of the sidebar links, and as a result the class attribute has a space at the end now (to make it easier to add a class under certain conditions).
  • PipelineNodeTest.submitInputPostBlock: Underlying issue is JENKINS-63516. This test doesn't really have anything to do with password parameters specifically, so we just remove the password parameter from the test to fix the PCT failures.
  • PipelineNodeTest.submitInputPostBlockWithParallelStages: Same as PipelineNodeTest.submitInputPostBlock.

Submitter checklist

  • Link to JIRA ticket in description, if appropriate.
  • Change is code complete and matches issue description
  • Appropriate unit or acceptance tests or explanation to why this change has no tests
  • Reviewer's manual test instructions provided in PR description. See Reviewer's first task below.

Reviewer checklist

  • Run the changes and verified the change matches the issue description
  • Reviewed the code
  • Verified that the appropriate tests have been written or valid explanation given

@dwnusbaum dwnusbaum requested review from olamy and bitwiseman August 26, 2020 20:26
@olamy olamy added the test label Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants