New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-58684] use sse gateway 1.20 #2021

Merged

olamy merged 2 commits into master from JENKINS-58684-sse-gateway-1.20

Aug 30, 2019

Member

olamy commented Aug 29, 2019 •

edited

Loading

Signed-off-by: olivier lamy [email protected]

Description

See JENKINS-58684.

Submitter checklist

Link to JIRA ticket in description, if appropriate.
Change is code complete and matches issue description
Appropriate unit or acceptance tests or explanation to why this change has no tests
Reviewer's manual test instructions provided in PR description. See Reviewer's first task below.

Reviewer checklist

Run the changes and verified the change matches the issue description
Reviewed the code
Verified that the appropriate tests have been written or valid explanation given


          [JENKINS-58684] use sse gateway 1.20

ccfa326

Signed-off-by: olivier lamy <[email protected]>

halkeye reviewed

View reviewed changes

pom.xml

-                    <url>http://repo.jenkins-ci.org/public/</url>
+                    <url>https://repo.jenkins-ci.org/public/</url>
+                    <snapshots>
+                      <enabled>true</enabled>

Member

halkeye Aug 29, 2019

I'm afraid I don't know maven too well, will enabling snapshots cause any errors? I assume you need to explicitly set the version to a snapshot

Member Author

olamy Aug 29, 2019

yes correct. I was using that because I tested with a SNAPSHOT version of sse.
If you use only fixed version this doesn't change anything

halkeye approved these changes

View reviewed changes

Member

halkeye commented Aug 29, 2019

[2019-08-29T01:49:33.903Z] [WARNING] Rule 5: org.apache.maven.plugins.enforcer.RequireUpperBoundDeps failed with message:

[2019-08-29T01:49:33.903Z] Failed while enforcing RequireUpperBoundDeps. The error(s) are [

[2019-08-29T01:49:33.903Z] Require upper bound dependencies error for commons-io:commons-io:2.4 paths to dependency are:

[2019-08-29T01:49:33.903Z] +-io.jenkins.blueocean:blueocean-events:1.18.0-rc4045.ccfa32645162

[2019-08-29T01:49:33.903Z] +-org.jenkins-ci.plugins:sse-gateway:1.20

[2019-08-29T01:49:33.903Z] +-commons-io:commons-io:2.4

[2019-08-29T01:49:33.903Z] and

[2019-08-29T01:49:33.903Z] +-io.jenkins.blueocean:blueocean-events:1.18.0-rc4045.ccfa32645162

[2019-08-29T01:49:33.903Z] +-org.jenkins-ci.main:jenkins-core:2.164.1

[2019-08-29T01:49:33.903Z] +-commons-io:commons-io:2.6

[2019-08-29T01:49:33.903Z] and

[2019-08-29T01:49:33.903Z] +-io.jenkins.blueocean:blueocean-events:1.18.0-rc4045.ccfa32645162

[2019-08-29T01:49:33.903Z] +-org.jenkins-ci.main:jenkins-core:2.164.1

[2019-08-29T01:49:33.903Z] +-org.jenkins-ci.main:cli:2.164.1

[2019-08-29T01:49:33.903Z] +-commons-io:commons-io:2.6

[2019-08-29T01:49:33.903Z] and

[2019-08-29T01:49:33.903Z] +-io.jenkins.blueocean:blueocean-events:1.18.0-rc4045.ccfa32645162

[2019-08-29T01:49:33.903Z] +-org.jenkins-ci.main:jenkins-core:2.164.1

[2019-08-29T01:49:33.903Z] +-org.jenkins-ci:crypto-util:1.1

[2019-08-29T01:49:33.903Z] +-commons-io:commons-io:1.4

[2019-08-29T01:49:33.903Z] and

[2019-08-29T01:49:33.903Z] +-io.jenkins.blueocean:blueocean-events:1.18.0-rc4045.ccfa32645162

[2019-08-29T01:49:33.903Z] +-org.jenkins-ci.main:jenkins-core:2.164.1

[2019-08-29T01:49:33.903Z] +-org.jenkins-ci:bytecode-compatibility-transformer:2.0-beta-2

[2019-08-29T01:49:33.903Z] +-commons-io:commons-io:2.4

[2019-08-29T01:49:33.903Z] and

[2019-08-29T01:49:33.903Z] +-io.jenkins.blueocean:blueocean-events:1.18.0-rc4045.ccfa32645162

[2019-08-29T01:49:33.903Z] +-org.jenkins-ci.main:jenkins-core:2.164.1

[2019-08-29T01:49:33.903Z] +-commons-fileupload:commons-fileupload:1.3.1-jenkins-2

[2019-08-29T01:49:33.903Z] +-commons-io:commons-io:2.2

[2019-08-29T01:49:33.903Z] and

[2019-08-29T01:49:33.903Z] +-io.jenkins.blueocean:blueocean-events:1.18.0-rc4045.ccfa32645162

[2019-08-29T01:49:33.903Z] +-org.jenkins-ci.main:jenkins-core:2.164.1

[2019-08-29T01:49:33.903Z] +-org.kohsuke.stapler:stapler-jrebel:1.256

[2019-08-29T01:49:33.903Z] +-org.kohsuke.stapler:stapler:1.256

[2019-08-29T01:49:33.903Z] +-commons-io:commons-io:2.4

[2019-08-29T01:49:33.903Z] ]

Member Author

olamy commented Aug 29, 2019

@halkeye ?? where do you get that? looks green here https://ci.blueocean.io/blue/organizations/jenkins/blueocean/detail/JENKINS-58684-sse-gateway-1.20/2/

Member

halkeye commented Aug 29, 2019

https://ci.jenkins.io/blue/organizations/jenkins/Plugins%2Fblueocean-plugin/detail/JENKINS-58684-sse-gateway-1.20/2/pipeline

Member Author

olamy commented Aug 29, 2019 •

edited

Loading

LOL and in both case it's Apache Maven 3.5.4 and BTW build fine locally no idea...

Member

halkeye commented Aug 29, 2019

I was able to reproduce it with the same command

mvn --batch-mode --show-version --errors -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn  --update-snapshots -Dmaven.test.failure.ignore -Dset.changelist -Djenkins.version=2.164.1 -Daccess-modifier-checker.failOnError=false -Djava.level=8 -DskipTests clean install -Dignore.dirt

 (ssh) cb-gavinmogan   JENKINS-58684-sse-gateway-1.20 ? ⍟4  …/git/jenkinsci/blueocean-plugin  mvn -version
Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 2019-04-04T12:00:29-07:00)
Maven home: /home/gmogan/.sdkman/candidates/maven/current
Java version: 1.8.0_202, vendor: Azul Systems, Inc., runtime: /home/gmogan/.sdkman/candidates/java/8.0.202-zulu/jre
Default locale: en_CA, platform encoding: UTF-8
OS name: "linux", version: "4.15.0-58-generic", arch: "amd64", family: "unix"

Member Author

olamy commented Aug 29, 2019

well ok I can fix that.
But that's crap to have such failure because of a different command line usage.
how a normal contributor could know that...
this should fail because of a normal build (i.e no extra parameters..)

Member

halkeye commented Aug 29, 2019

Yea you'll have to ask upstream why that happened. Maybe the new parent pom or something. It used to report an error.

I'm thinking it might actually be a ci issue, I think they changed the enforcer settings to ignore test deps?


          fix upperbound dependency on commons-io

76a5651

Signed-off-by: olivier lamy <[email protected]>

Member Author

olamy commented Aug 30, 2019

@halkeye maybe we can merge it now?

Member

halkeye commented Aug 30, 2019

java.lang.AssertionError: nodes != 9:[PipelineNodeImpl{node=io.jenkins.blueocean.rest.impl.pipeline.FlowNodeWrapper[id=6,displayName=first-solo,type=STAGE], edges=[io.jenkins.blueocean.rest.impl.pipeline.PipelineNodeImpl$EdgeImpl@166b42ea], status=io.jenkins.blueocean.rest.impl.pipeline.NodeRunStatus@5d6e6c83}, PipelineNodeImpl{node=io.jenkins.blueocean.rest.impl.pipeline.FlowNodeWrapper[id=12,displayName=parent,type=STAGE], edges=[io.jenkins.blueocean.rest.impl.pipeline.PipelineNodeImpl$EdgeImpl@6adc1172], status=io.jenkins.blueocean.rest.impl.pipeline.NodeRunStatus@6fe07eb2}, PipelineNodeImpl{node=io.jenkins.blueocean.rest.impl.pipeline.FlowNodeWrapper[id=20,displayName=single-stage,type=STAGE], edges=[], status=io.jenkins.blueocean.rest.impl.pipeline.NodeRunStatus@23d01db6}]

Yea, the failed test is flakey, has been for a few months, maybe #2017 will fix it

But yea, I approved it, go ahead and merge

olamy merged commit 42ddd44 into master

olamy deleted the JENKINS-58684-sse-gateway-1.20 branch

August 30, 2019 01:55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet