Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-51716] Prevent non numeric run id from throwing exception when a run is actually found #1932

Merged
merged 2 commits into from
Mar 19, 2019

Conversation

halkeye
Copy link
Member

@halkeye halkeye commented Mar 7, 2019

Description

See JENKINS-51716.

Super hard to test manually, since you need to have runs that have non numeric id. I believe jenkins has deprecated id, so most jobs will be null or a number.

If you can get that, then testing is just hitting any rest interface that returns the run. The front page will try and return the latest run for a job.

Submitter checklist

  • Link to JIRA ticket in description, if appropriate.
  • Change is code complete and matches issue description
  • Appropriate unit or acceptance tests or explanation to why this change has no tests
  • Reviewer's manual test instructions provided in PR description. See Reviewer's first task below.

Reviewer checklist

  • Run the changes and verified the change matches the issue description
  • Reviewed the code
  • Verified that the appropriate tests have been written or valid explanation given

@sophistifunk
Copy link
Collaborator

bbm-bueno

Copy link
Collaborator

@NicuPascu NicuPascu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sophistifunk sophistifunk merged commit 663c236 into master Mar 19, 2019
@sophistifunk sophistifunk deleted the JENKINS-51716-non-numeric-build-id branch March 19, 2019 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants