-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add client certificate support #596
Add client certificate support #596
Conversation
src/main/java/com/microsoft/jenkins/azuread/AzureSecurityRealm.java
Dismissed
Show dismissed
Hide dismissed
src/main/java/com/microsoft/jenkins/azuread/GraphClientCacheKey.java
Dismissed
Show resolved
Hide resolved
@timja Please review |
src/main/java/com/microsoft/jenkins/azuread/AzureSecurityRealm.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested that client secret still works and made some minor UI tweaks.
I haven't tested the client secret functionality but code looks good
src/main/java/com/microsoft/jenkins/azuread/AzureSecurityRealm.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/jenkins/azuread/AzureSecurityRealm.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/jenkins/azuread/GraphClientCache.java
Outdated
Show resolved
Hide resolved
src/main/resources/com/microsoft/jenkins/azuread/AzureSecurityRealm/config.jelly
Show resolved
Hide resolved
src/main/resources/com/microsoft/jenkins/azuread/AzureSecurityRealm/config.jelly
Show resolved
Hide resolved
You meant you haven't tested the client certificate right? I have tested it with two different certificates and it functions as expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really close, I think the tests could be improved a little bit though
src/test/java/com/microsoft/jenkins/azuread/integrations/casc/ConfigAsCodeCertificateTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/microsoft/jenkins/azuread/integrations/casc/ConfigAsCodeCertificateTest.java
Outdated
Show resolved
Hide resolved
There are some whitespace issues: removal of final newlines in files, varying numbers of blank lines between methods, extra indentation in one method. Not a big deal though. |
src/main/java/com/microsoft/jenkins/azuread/GraphClientCacheKey.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/jenkins/azuread/GraphClientCacheKey.java
Outdated
Show resolved
Hide resolved
src/test/java/com/microsoft/jenkins/azuread/integrations/casc/BaseConfigAsCodeTest.java
Outdated
Show resolved
Hide resolved
src/test/resources/com/microsoft/jenkins/azuread/integrations/casc/ConfigAsCodeTest/config.xml
Outdated
Show resolved
Hide resolved
Co-authored-by: Tim Jacomb <[email protected]>
Thanks for the contribution! |
Testing done
Submitter checklist