Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gson-api-plugin and update to Jenkins 2.414.3 and minor updates and improvements #556

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

StefanSpieker
Copy link
Contributor

@StefanSpieker StefanSpieker commented Apr 4, 2024

Use gson-api-plugin as suggested by (#549)
and updated:

and minor improvements

  • removed explicit version of matrix-auth, because 3.2.1 seems to be sufficient
  • removed explicit test dependency of JUnit 4

Testing done

  • Maven install locally passes.
  • Started an interactive debugging session, but did not really connect to an Entra ID instance. Just checked the configure screen and the try connect button.

Submitter checklist

@timja timja added the developer label Apr 4, 2024
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you bump the baseline and bom to one of the versions on https://www.jenkins.io/doc/developer/plugin-development/choosing-jenkins-baseline/ please? that way the latest bom can be used too

@StefanSpieker StefanSpieker changed the title Use gson-api-plugin and update to Jenkins 2.401.3 and minor updates and improvements Use gson-api-plugin and update to Jenkins 2.414.3 and minor updates and improvements Apr 4, 2024
@StefanSpieker
Copy link
Contributor Author

bumped to 2.414.3 because 98% of the users, which use the latest version are on this or a newer version

Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@timja timja merged commit dfa2441 into jenkinsci:master Apr 4, 2024
14 checks passed
@StefanSpieker StefanSpieker deleted the gson-api branch April 4, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants