[JENKINS-73649] Use AWS SDK for Java 2.x #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basil
commented
Nov 26, 2024
src/main/java/com/cloudbees/jenkins/plugins/awscredentials/AWSCredentialsImpl.java
Outdated
Show resolved
Hide resolved
...n/java/com/cloudbees/jenkins/plugins/awscredentials/AmazonWebServicesCredentialsBinding.java
Show resolved
Hide resolved
basil
changed the title
basil
force-pushed
the
aws-java-sdk2
branch
3 times, most recently
from
09c5338 to
c923c9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested in context by calling the
doCheckSecretKeyvalidation endpoint and verifying that validation succeeded using the AWS SDK for Java 2.x and that the call to EC2 succeeded. Took away EC2 read permissions and confirmed the correct error message was displayed. Created a Squid proxy and verified that validation still succeeded through the proxy. Took down the proxy and verified that validation failed when the proxy was configured but not responding. Tested the compatibility layer by running a Pipeline job with unmodifiedaws-global-credentialsandartifact-manager-s3plugins, and verified that the artifact showed up in S3.