New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replacing JSR-305 javax.annotations with Spotbugs #193

Merged

Vlatombe merged 1 commit into jenkinsci:master from aneveux:fix-jsr-305

Mar 3, 2023

Member

aneveux commented Feb 2, 2023 •

edited

Loading

Hello folks 👋

I'm currently following the Improve a Plugin documentation for
Jenkins plugins modernization, and noticed we could replace JSR 305 annotations for this plugin.

So here's a PR doing that. I checked that everything is running fine with mvn verify.

Thanks for your review!

Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
Ensure that the pull request title represents the desired changelog entry
Please describe what you did
Link to relevant issues in GitHub or Jira
Link to relevant pull requests, esp. upstream and downstream changes
Ensure you have provided tests - that demonstrates feature works or fixes the issue


          Replacing JSR-305 javax.annotations with Spotbugs

b8bf333

Vlatombe added the chore label

Vlatombe approved these changes

View reviewed changes

Vlatombe merged commit 988e0ce into jenkinsci:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels