Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase spotbugs checks and fix redundant interface declaration #189

Merged
merged 1 commit into from
Mar 3, 2023

Conversation

aneveux
Copy link
Member

@aneveux aneveux commented Jan 5, 2023

Hello folks 👋

I'm currently following the Improve a Plugin documentation for
Jenkins plugins modernization, and noticed we could add more spotbugs checks for this plugin.

By doing so and running mvn -DskipTests verify, Spotbugs reported that com.cloudbees.jenkins.plugins.awscredentials.AWSCredentialsImpl was implementing the interface AmazonWebServicesCredentials, but so is BaseAmazonWebServicesCredentials, which AWSCredentialsImpl extends, so I removed that redundant interface declaration.

I checked that everything was still fine with mvn verify and everything looks good.

Let me know if I missed anything with this PR.

Thanks a lot for your review!

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@aneveux aneveux requested a review from Vlatombe January 5, 2023 17:32
@aneveux
Copy link
Member Author

aneveux commented Mar 2, 2023

Hello @jglick , @Vlatombe ,

Can I get a quick review on that one please? ❤️

@Vlatombe Vlatombe added the chore label Mar 3, 2023
@Vlatombe Vlatombe merged commit 0ff19c5 into jenkinsci:master Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants