Increase spotbugs checks and fix redundant interface declaration #189
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello folks 👋
I'm currently following the Improve a Plugin documentation for
Jenkins plugins modernization, and noticed we could add more spotbugs checks for this plugin.
By doing so and running
mvn -DskipTests verify
, Spotbugs reported thatcom.cloudbees.jenkins.plugins.awscredentials.AWSCredentialsImpl
was implementing the interfaceAmazonWebServicesCredentials
, but so isBaseAmazonWebServicesCredentials
, whichAWSCredentialsImpl
extends, so I removed that redundant interface declaration.I checked that everything was still fine with
mvn verify
and everything looks good.Let me know if I missed anything with this PR.
Thanks a lot for your review!