Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating parent pom and bom #188

Merged
merged 3 commits into from
Mar 2, 2023
Merged

Conversation

aneveux
Copy link
Member

@aneveux aneveux commented Jan 5, 2023

Hello folks 👋

I'm currently following the Improve a Plugin documentation for
Jenkins plugins modernization, and noticed we could update the parent pom for this plugin.

So here's a PR doing that. I checked that everything is running fine with mvn verify and removed unnecessary
upperbounds dependencyManagement.

Thanks for your review!

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@aneveux aneveux requested a review from Vlatombe January 5, 2023 17:12
@aneveux
Copy link
Member Author

aneveux commented Mar 2, 2023

Hello @jglick, @Vlatombe 👋

Can you please have a look at that PR? ❤️

Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but I do not have write access.

@Vlatombe Vlatombe merged commit 4a36eee into jenkinsci:master Mar 2, 2023
@Vlatombe Vlatombe added the chore label Mar 2, 2023
@aneveux aneveux deleted the update-parent-pom branch March 2, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants