Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check a condition rather than catch an exception #49

Merged
merged 4 commits into from
Mar 21, 2023

Conversation

jglick
Copy link
Member

@jglick jglick commented Aug 28, 2020

Not necessary for jenkinsci/jenkins#4848 but should clean up a false positive from code search for dangerous idioms.

@MarkEWaite MarkEWaite added the chore Reduces maintenance effort by changes not directly visible to users label Mar 21, 2023
@MarkEWaite MarkEWaite changed the title More straightforward to directly check a condition than to catch an exception Check a condition rather than catch an exception Mar 21, 2023
@MarkEWaite MarkEWaite enabled auto-merge (squash) March 21, 2023 15:41
@MarkEWaite MarkEWaite merged commit 97281cd into jenkinsci:master Mar 21, 2023
@jglick jglick deleted the spring-5303 branch March 21, 2023 17:55
@jglick
Copy link
Member Author

jglick commented Mar 21, 2023

@MarkEWaite
Copy link
Contributor

MarkEWaite commented Mar 21, 2023

https://github.com/jenkinsci/authorize-project-plugin/releases does not mention the new release @MarkEWaite.

Unfortunately, I have write permission to the GitHub repository but don't yet have write permission to the artifact repository. The 1.5.0 tag has been placed on the GitHub repository but won't ever arrive on the artifact repository.

When jenkins-infra/repository-permissions-updater#3204 is merged I'll fix my mistake by delivering either 1.5.1 or 1.6.0. I don't want to publish the release on GitHub until I'm confident that it is available in the artifact repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Reduces maintenance effort by changes not directly visible to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants