[JENKINS-73958] remove eval call from js #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basil
reviewed
Oct 17, 2024
| @@ -74,8 +74,10 @@ Behaviour.specify(".specific-user-authorization", "checkPasswordRequired", 0, fu | |||
|
|
|||
| var onchange = function(evt) { | |||
| var url = useridField.getAttribute("checkPasswordRequestedUrl"); | |||
| url = eval(url); | |||
| fetch(url, { | |||
| var params = new URLSearchParams({ | |||
There was a problem hiding this comment.
A while back we had problems with URLSearchParams not working in HtmlUnit, so I would feel more comfortable with a PCT run to make sure this won't cause unnecessary hassle in test coverage. An ATH run wouldn't hurt too, but I won't insist on it.
There was a problem hiding this comment.
MarkEWaite
added a commit
to MarkEWaite/bom
that referenced
this pull request
Oct 17, 2024
jenkinsci/authorize-project-plugin#269 fixes a content security policy problem in the plugin. Let's be sure that the change does not harm any tests in the plugin BOM.
6 tasks
MarkEWaite
added a commit
to MarkEWaite/acceptance-test-harness
that referenced
this pull request
Oct 17, 2024
jenkinsci/authorize-project-plugin#269 is the pull request.
6 tasks
MarkEWaite
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing done
manual testing
Submitter checklist