Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update parent pom #106

Merged
merged 5 commits into from
Nov 8, 2022
Merged

Update parent pom #106

merged 5 commits into from
Nov 8, 2022

Conversation

MarkEWaite
Copy link
Contributor

Update parent pom and require Jenkins 2.332.4 or newer

  • Convert property files to unambiguous encoded form
  • Require Jenkins 2.332.4
  • Use parent pom 4.49, not 4.16
  • Remove unused java.level property
  • Test more configurations in CI

Update the parent pom to 4.49. That change also required an update of the minimum Jenkins version and conversion of Japanese language property files to unambiguous encoded form.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@MarkEWaite
Convert property files to unambiguous encoded form
ebbc900 
Japanese files include characters that could be confused with ISO-8859-1
characters.  Convert them all to encoded ASCII so that there is no
ambiguity.

Resolves a warning from the an injected test.
@MarkEWaite
Require Jenkins 2.332.4
d30c73e 
https://www.jenkins.io/doc/developer/plugin-development/choosing-jenkins-baseline/
recommends 2.332.4 as a good minimum core version.
@MarkEWaite
Use parent pom 4.49, not 4.16
f4fc8fa 
Also removes the java.level property
@MarkEWaite
Remove unused java.level property
ce0cb42
@MarkEWaite
Test more configurations in CI
89359fe
@MarkEWaite MarkEWaite enabled auto-merge November 7, 2022 22:44
@MarkEWaite MarkEWaite mentioned this pull request Nov 7, 2022
Closed
gounthar
gounthar approved these changes Nov 8, 2022
View reviewed changes
Copy link

@gounthar gounthar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks. 👍
Nice work on the Japanese properties by the way. 🚀

jmMeessen
jmMeessen approved these changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@jmMeessen jmMeessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarkEWaite MarkEWaite merged commit d068a4e into jenkinsci:master Nov 8, 2022
@MarkEWaite MarkEWaite deleted the update-parent-pom branch November 8, 2022 14:25
@MarkEWaite MarkEWaite added the dependencies Dependency related change label Mar 21, 2023
@MarkEWaite MarkEWaite mentioned this pull request Mar 21, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gounthar gounthar gounthar approved these changes

@jmMeessen jmMeessen jmMeessen approved these changes

Assignees
No one assigned
Labels
dependencies Dependency related change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarkEWaite @gounthar @jmMeessen