-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add parser for aquasec trivy container vulnability scanner #542
Conversation
Can you please have a look at the analysis issues first? |
Codecov Report
@@ Coverage Diff @@
## master #542 +/- ##
============================================
- Coverage 90.15% 90.14% -0.01%
- Complexity 1573 1583 +10
============================================
Files 175 176 +1
Lines 4762 4799 +37
Branches 520 525 +5
============================================
+ Hits 4293 4326 +33
- Misses 297 299 +2
- Partials 172 174 +2
Continue to review full report at Codecov.
|
now it looks well, a 93,1% coverage should be good enough |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your pull request!
Does it make sense to check for the correct file ending? Then please add a test like
https://github.com/jenkinsci/analysis-model/blob/master/src/test/java/edu/hm/hafner/analysis/parser/HadoLintParserTest.java#L50
(In this example you can also see a test with corrupt input)
src/test/java/edu/hm/hafner/analysis/parser/TrivyParserTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Ullrich Hafner <[email protected]>
Co-authored-by: Ullrich Hafner <[email protected]>
Co-authored-by: Ullrich Hafner <[email protected]>
Thanks for the review. |
irrelevant vulnerabilities
I do not understand why I will break the API. Please advice... |
Can you please update the version in |
I'm wondering the version should be already 9.5.0-SNAPSHOT maybe i need to increase once again after the rebase. next try with 9.6.0-SNAPSHOT |
No description provided.