Fix environment variables resolution #371
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using a deprecated perform method without the env parameter coming from it, meaning we were not getting environment variables sent to the build from Jenkinsfile, for example.
Updated the perform and generateReport methods to inherit and use the proper environment variables set by the user.
Resolves #360
)
Testing done
I've tested it local and in our company pipeline that were failing as we couldn't set the JAVA_HOME for the allure command to run.
Before: Even though JAVA_HOME was properly set, as we can see from the logs, the execution failed
After: Properly found the JAVA_HOME sent as a parameter and created the allure report
For a pipeline we had running in linux in which we sent the jdk parameter it continued working as before.
Submitter checklist