Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to dialog changes in matrix-auth 3.2.3 #1804

Merged
merged 3 commits into from
Oct 23, 2024

Conversation

daniel-beck
Copy link
Member

@daniel-beck daniel-beck commented Oct 23, 2024

Fixes #1803

Testing done

BROWSER=firefox JENKINS_VERSION=2.462.3 mvn test -Dtest=MatrixAuthPluginTest
BROWSER=firefox JENKINS_VERSION=2.462.3 VERSION_OVERRIDES=matrix-auth=3.2.2 mvn test -Dtest=MatrixAuthPluginTest
BROWSER=firefox JENKINS_VERSION=2.462.3 VERSION_OVERRIDES=matrix-auth=3.2.3 mvn test -Dtest=MatrixAuthPluginTest

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@timja timja merged commit 122bbab into jenkinsci:master Oct 23, 2024
25 checks passed
@daniel-beck daniel-beck deleted the fix-1803 branch October 23, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default branch destabilized with 26 new test failures
2 participants