Add link icon to release card header #1492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbynek
commented
Sep 3, 2023
| @@ -7,10 +7,6 @@ function Pagination({limit, page, pages, total, setPage}) { | |||
| const [pagesToDisplay, setPagesToDisplay] = React.useState(5); | |||
| const [marginPagesDisplayed, setMarginPagesDisplayed] = React.useState(2); | |||
|
|
|||
| if (total == 0) { | |||
There was a problem hiding this comment.
The only place where Pagiation is called guards for total == 0 already
|
Looks good to me, but the build thinks otherwise |
halkeye
reviewed
Sep 8, 2023
| @@ -53,7 +53,7 @@ function PluginReleases({pluginId, versions}) { | |||
| <a href={release.htmlURL} title="See the release on GitHub" className="github-icon d-flex"><ion-icon name="logo-github" /></a> | |||
| </>)} | |||
| <a className="anchor after" href={`#version_${version.version}`}> | |||
| <ion-icon name="link-outline"></ion-icon> | |||
| <ion-icon name="link-outline"/> | |||
There was a problem hiding this comment.
I believe web components must have closing tags, not self closing.
There was a problem hiding this comment.
You're right, self-closing custom elements are still not valid HTML (as far as I understand WICG/webcomponents#624 ), but
- ESlint prefers self-closing tags and we're using it this way for all icons in the repo
- This is .jsx so HTML parsing restrictions do not apply
halkeye
reviewed
Sep 8, 2023
Co-authored-by: Gavin Mogan <[email protected]>
NotMyFault
approved these changes
Sep 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1273 (the remaining part)
Also fixes some of the warnings Gatsby now produces in dev mode.