Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update minimum recommended baseline based on supported update centers #3002

Merged
merged 1 commit into from
Mar 26, 2020
Merged

Update minimum recommended baseline based on supported update centers #3002

merged 1 commit into from
Mar 26, 2020

Conversation

timja
Copy link
Member

@timja timja commented Mar 25, 2020

No description provided.

@timja timja requested a review from a team as a code owner March 25, 2020 16:36
@probot-autolabeler probot-autolabeler bot added the documentation Jenkins documentation, including user and developer docs, solution pages, etc. label Mar 25, 2020
daniel-beck
daniel-beck approved these changes Mar 25, 2020
View reviewed changes
Copy link
Contributor

@daniel-beck daniel-beck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder whether this could be done more dynamically, but would probably require a HAML rewrite of this page, plus more scripting.

@daniel-beck
Copy link
Contributor

BTW, do we justify this anywhere? (It'd be easy to, I'm not questioning it.)

@timja
Copy link
Member Author

timja commented Mar 25, 2020

The 3 lines above it give some justification

@daniel-beck
Copy link
Contributor

The 3 lines above it give some justification

For the general principle, yes, but not the hard cutoff defined here, in bold. 2.164 is the first LTS baseline after several to actually make a difference with detached plugins.

@MarkEWaite MarkEWaite mentioned this pull request Mar 26, 2020
Merged
@oleg-nenashev oleg-nenashev merged commit 189d077 into jenkins-infra:master Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleg-nenashev oleg-nenashev oleg-nenashev approved these changes

@daniel-beck daniel-beck daniel-beck approved these changes

@MarkEWaite MarkEWaite MarkEWaite approved these changes

Assignees
No one assigned
Labels
documentation Jenkins documentation, including user and developer docs, solution pages, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@timja @daniel-beck @MarkEWaite @oleg-nenashev