-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(doks,doks-public) create infraciadmin SA for each cluster along with their token and kubeconfigs #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with their token and kubeconfigs Signed-off-by: Damien Duportal <[email protected]>
dduportal
changed the title
feat(doks,doks-public) create infraciadmin SA for each cluster along …
feat(doks,doks-public) create infraciadmin SA for each cluster along with their token and kubeconfigs
Aug 8, 2023
timja
previously approved these changes
Aug 8, 2023
lemeurherve
previously approved these changes
Aug 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Hervé Le Meur <[email protected]>
For info: this PR failed to be applied. The error was Opened jenkins-infra/docker-hashicorp-tools#320 to fix |
This was referenced Aug 8, 2023
dduportal
added a commit
to jenkins-infra/azure
that referenced
this pull request
Aug 9, 2023
…m module (#448) Ref. jenkins-infra/helpdesk#3679 Same as jenkins-infra/digitalocean#134 + jenkins-infra/digitalocean#136 but for Azure Please note that the `privatek8s` SA can be used directly by the pod of jenkins-infra/kubernetes-management by mounting the token in the pod directly. Signed-off-by: Damien Duportal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to jenkins-infra/helpdesk#3679
This PRs adds the jenkinsciinfraadmin to both
doks
anddoks-public
clusters.Notes:
do_token
as been removed in favor of using theDIGITALOCEAN_ACCESS_TOKEN
relying on thedoctl
command. It was required to ensure that thekubernetes
provider where able to access the clusters to bootstrap the SAs.But I want to validate end to end the usage of this solution before factorizing