Azure AD Application password for Azure VM agents in `trusted.ci.jenk…

…ins.io` expires on `2024-11-20T00:00:00Z` (#869)

This PR updates the Azure AD application password used in
`trusted.ci.jenkins.io` controller to spawn Azure VM agents.

The current end date is set to `2024-11-20T00:00:00Z`.

> [!IMPORTANT]
>
> ⚠️ Merging this PR will prevent starting new Azure VM agents until the
credential is updated on the controller.

You'll have to update **manually** the top-level credential
`azure-jenkins-sponsorship-credentials` on the Jenkins UI.

The new password value, once the PR is merged and deployed, can be
retrieved from the Terraform state,
by searching for
`module.trusted_ci_jenkins_io.azuread_application_password.controller`.

Finally, verify both Azure Credential and Azure VM clouds by checking
that a click on the "Verify <...>" buttons returns a success,
then restart the controller to ensure that the old credential is not
kept in cache.


---



<Actions>
<action
id="ab61385ee3fa09084aa4842b5a9d9c2ca4dc882f77fac205278e30fe8907f328">
<h3>Generate new end date for the trusted.ci.jenkins.io controller Azure
AD Application password</h3>
<details
id="4191ba5f46dbb754c1e7d30549ffcee986a6a05817c850ea79cf471743ba992d">
<summary>Update Terraform file `trusted.ci.jenkins.io.tf` with new
expiration date</summary>
<p>changes detected:&#xA;&#x9;path
&#34;module.controller_service_principal_end_date&#34; updated from
&#34;2024-11-20T00:00:00Z&#34; to &#34;2025-02-16T00:00:00Z&#34; in file
&#34;trusted.ci.jenkins.io.tf&#34;</p>
        </details>
<a
href="https://infra.ci.jenkins.io/job/updatecli/job/azure/job/main/537/">Jenkins
pipeline link</a>
    </action>
</Actions>

---

<table>
  <tr>
    <td width="77">
<img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli
logo" width="50" height="50">
    </td>
    <td>
      <p>
Created automatically by <a
href="https://www.updatecli.io/">Updatecli</a>
      </p>
      <details><summary>Options:</summary>
        <br />
<p>Most of Updatecli configuration is done via <a
href="https://www.updatecli.io/docs/prologue/quick-start/">its
manifest(s)</a>.</p>
        <ul>
<li>If you close this pull request, Updatecli will automatically reopen
it, the next time it runs.</li>
<li>If you close this pull request and delete the base branch, Updatecli
will automatically recreate it, erasing all previous commits made.</li>
        </ul>
        <p>
Feel free to report any issues at <a
href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br
/>
If you find this tool useful, do not hesitate to star <a
href="https://github.com/updatecli/updatecli/stargazers">our GitHub
repository</a> as a sign of appreciation, and/or to tell us directly on
our <a
href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>!
        </p>
      </details>
    </td>
  </tr>
</table>

Co-authored-by: Jenkins Infra Bot (updatecli) <[email protected]>

trusted.ci.jenkins.io.tf

@@ -45,7 +45,7 @@ module "trusted_ci_jenkins_io" {
     # data.azuread_service_principal.terraform_production.id,
     "b847a030-25e1-4791-ad04-9e8484d87bce",
   ]
-  controller_service_principal_end_date = "2024-11-20T00:00:00Z"
+  controller_service_principal_end_date = "2025-02-16T00:00:00Z"
   controller_packer_rg_ids = [
     azurerm_resource_group.packer_images["prod"].id
   ]