Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mod_jem 4.3.1 deprecated htmlspecialchars --> sometimes changings are made too quickly! #1860

Open
jojo12 opened this issue Nov 23, 2024 · 3 comments
Labels
bug Something isn't working deprecated testing needed
Milestone

Comments

@jojo12
Copy link
Contributor

jojo12 commented Nov 23, 2024

mod_jem 4.3.1 was changed: now there is a deprecated warning (back again!): helpers.php line 139-141:

` $lists[$i]->postalCode = htmlspecialchars($row->postalCode, ENT_COMPAT, 'UTF-8');
$lists[$i]->street = htmlspecialchars($row->street, ENT_COMPAT, 'UTF-8');
$lists[$i]->state = htmlspecialchars($row->state, ENT_COMPAT, 'UTF-8');

should be
` $lists[$i]->postalCode = htmlspecialchars($row->postalCode ?? '', ENT_COMPAT, 'UTF-8');
$lists[$i]->street = htmlspecialchars($row->street ?? '', ENT_COMPAT, 'UTF-8');
$lists[$i]->state = htmlspecialchars($row->state ?? '', ENT_COMPAT, 'UTF-8');

(Thanks to kurtus in the forum)

@jojo12 jojo12 added the bug Something isn't working label Nov 23, 2024
@Heklaterriol
Copy link
Contributor

Heklaterriol commented Nov 25, 2024

Are you talking about /modules/mod_jem/helper.php?
I suspect it was me - I added these lines for the microdata.

@Heklaterriol
Copy link
Contributor

Cloud you please test, if the changes are ok.

@jojo12
Copy link
Contributor Author

jojo12 commented Nov 26, 2024

The deprecated warning came from @kurtus in the forum. He is on 4.4.9. On this I can't test.
Are there other modules you added "quickly"?

@jojo12 jojo12 added this to the JEM 4.3.2 milestone Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working deprecated testing needed
Projects
None yet
Development

No branches or pull requests

2 participants