Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(backdrop): add test for backdrop store #532

Merged
merged 1 commit into from
Jan 14, 2021
Merged

Conversation

camc314
Copy link
Contributor

@camc314 camc314 commented Jan 10, 2021

Adds Tests for:

  • committing 'SET_CURRENT_BACKDROP'
  • committing 'CLEAR_CURRENT_BACKDROP'
  • dispatching 'setBackdrop'
  • dispatching 'clearBackdrop'
  • gettter 'getBackdropBlurhash'

@camc314 camc314 marked this pull request as ready for review January 10, 2021 18:01
@camc314 camc314 added the tests Pull requests that improve testing label Jan 10, 2021
@ferferga
Copy link
Member

@camc314 Backdrop store is completely refactored on #520, the fixes that you're applying here are already there. You can rebase the commit without your changes in it, so no need to fix conflicts later.

@camc314
Copy link
Contributor Author

camc314 commented Jan 10, 2021

I'll rebase on 520

@camc314 camc314 marked this pull request as draft January 13, 2021 23:10
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@camc314 camc314 marked this pull request as ready for review January 14, 2021 15:31
@camc314
Copy link
Contributor Author

camc314 commented Jan 14, 2021

Rebased and ready for review

@codecov-io
Copy link

Codecov Report

Merging #532 (ad8fc2b) into master (381b061) will increase coverage by 0.75%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #532      +/-   ##
=========================================
+ Coverage    2.23%   2.99%   +0.75%     
=========================================
  Files          97      97              
  Lines        2635    2635              
  Branches      417     417              
=========================================
+ Hits           59      79      +20     
+ Misses       2574    2553      -21     
- Partials        2       3       +1     
Impacted Files Coverage Δ
components/Layout/HomeHeader/HomeHeaderItems.vue 0.00% <ø> (ø)
pages/playback/index.vue 0.00% <0.00%> (ø)
store/backdrop.ts 83.33% <100.00%> (+83.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 381b061...ad8fc2b. Read the comment docs.

@camc314 camc314 merged commit 88d7fc6 into master Jan 14, 2021
@camc314 camc314 deleted the backdrop-test branch January 14, 2021 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Pull requests that improve testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants