-
-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dark-theme): add dark theme colors #391
Conversation
84e1891
to
2990078
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #391 +/- ##
=========================================
- Coverage 0.60% 0.59% -0.01%
=========================================
Files 88 88
Lines 2312 2344 +32
Branches 353 355 +2
=========================================
Hits 14 14
- Misses 2297 2329 +32
Partials 1 1 ☔ View full report in Codecov by Sentry. |
2990078
to
88a595d
Compare
88a595d
to
05428e2
Compare
This should be pretty much ready for review. Though it only handles the dark theme. We'll have to see if we want t specific color scheme for the light theme or not. I'm thinking of going for something with the same general hue/saturation as the dark one, but a lot lighter, if only to get away from pure white. |
I agree that pure white can be jarring, but Github for instance has a pure white background. But to complement it there are dark accents, for instance on the top bar. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
05428e2
to
cad4990
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This branch somehow uses Roboto instead of Noto.
Imports needs to happen in this order: I tried adding the fontsource imports to variables.scss but it seems that they got imported for every single component, resulting in a bundle size over 100 MB.
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
We apparently don't need to import the style in the variables at all :) I reworked the file based on this: https://github.com/nuxt-community/vuetify-module#customvariables Not including the import at the end works properly, so I left it out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now, nothing else to comment aside from what I mention here
Updated 2020/01/08