Fix searching for admin #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuaboniface
approved these changes
Apr 14, 2022
1337joe
reviewed
Apr 14, 2022
Comment on lines
105
to
109
| var adminBaseDn = LdapPlugin.Instance.Configuration.LdapAdminBaseDn; | ||
| if (string.IsNullOrEmpty(adminBaseDn)) | ||
| { | ||
| adminBaseDn = ldapUser.Dn; | ||
| } |
There was a problem hiding this comment.
Removing this at least partially breaks PR #113 that went in a couple weeks ago
|
On my server (fresh install when we hit beta) with the current plugin release (14) I'm seeing correct behavior regarding admin users having admin rights and other users not. I think this is a result of the last pull request (specifically the change to search |
|
It may differ between LDAP implementations- I'm usin LLDAP, which doesn't support searching by a non ldap admin user. While this implementation is likely slower as it queries for all admin users and then goes through the list, but at least there shouldn't be any false positives |
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current release sets everyone as admin... so that's an issue