fix: bump version for protected branches #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the auto bump does not work for protected branches, which some plugins have configured
yq is already included in new GitHub Action virtual-environments in a recent enough version
h1dden-da3m0n
added
dependency
|
Just to make sure I'm reading this correctly- this change requires all plugins that use the workflows to have a |
|
Nope its optional. (on porous) However, if we opt to not have it my vote would go for setting the assembly version in ALL plugins to version |
crobibero
approved these changes
May 8, 2022
This was referenced May 15, 2022
This was referenced May 15, 2022
oddstr13
added a commit
to oddstr13/jellyfin-plugin-repository-manager
that referenced
this pull request
Mar 29, 2024
Only supports `Directory.Build.props` in base directory. Should fix jellyfin/jellyfin#11238 Related to changes in jellyfin/jellyfin-meta-plugins#27 See also jellyfin/jellyfin-plugin-webhook#116 for PR adding this file. See https://learn.microsoft.com/en-us/visualstudio/msbuild/customize-by-directory?view=vs-2022 for documentation on the file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sorry for taking so long with this simple fix, but live got in the way and motivation bit hard to build up.
This PR will reintroduce the version bump to the 'changelog' workflow that then gets part of the generated PRs.
Changes
Issues