-
-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NE10 to enable more neon optimization for libopus #518
Merged
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
25f1cc2
Add NE10 to enable more neon optimization for libopus
gnattu 191e8f6
builder: explict set traget arch for libne10
gnattu ef6fd85
builder: set explicit optimization CFLAGS for opus
gnattu 80bf279
builder: use custom fork of libNE10
gnattu 3756ca7
builder: use fPIC for Linux libopus
gnattu 453273e
Fix indent
gnattu cde1084
builder: just append optimization flags
gnattu 3a595cd
Fix indent
gnattu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
#!/bin/bash | ||
|
||
SCRIPT_REPO="https://github.com/gnattu/Ne10.git" | ||
SCRIPT_COMMIT="545f4f18014cdbf9fb5fb1a9f5d24000200dfa8b" | ||
|
||
ffbuild_enabled() { | ||
[[ $TARGET == win* ]] && return -1 | ||
[[ $TARGET == *arm64 ]] && return 0 | ||
return -1 | ||
} | ||
|
||
ffbuild_dockerbuild() { | ||
git-mini-clone "$SCRIPT_REPO" "$SCRIPT_COMMIT" Ne10 | ||
cd Ne10 | ||
|
||
mkdir -p build && cd build | ||
|
||
local myconf=( | ||
-DGNULINUX_PLATFORM=ON # macOS is also "GNU Linux". This target means all unix-like target | ||
) | ||
|
||
if [[ $TARGET == linux* ]]; then | ||
myconf+=( | ||
-DCMAKE_TOOLCHAIN_FILE="$FFBUILD_CMAKE_TOOLCHAIN" | ||
) | ||
elif [[ $TARGET == mac* ]]; then | ||
: | ||
else | ||
echo "Unknown target" | ||
return -1 | ||
fi | ||
|
||
export NE10_LINUX_TARGET_ARCH=aarch64 | ||
cmake .. "${myconf[@]}" | ||
make -j$(nproc) | ||
# NE10 does not have install method, we have to copy files with shell command | ||
cp modules/libNE10.a "$FFBUILD_PREFIX"/lib/libNE10.a | ||
cp -R ../inc "$FFBUILD_PREFIX"/include/libNE10 | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like optimizations being completely disabled only happens on macOS builds? I don't see the
!DEFINED(__OPTIMIZED__)
warning on crosstool-ng builds.Opus have this in their macOS CI:
So maybe this will be enough for both platforms: